Skip to content

Update op-geth for geth-based build #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danyalprout merged 1 commit into from
Jun 16, 2025
Merged

Update op-geth for geth-based build #473

danyalprout merged 1 commit into from
Jun 16, 2025

Conversation

@drwtsn95
Copy link
Contributor

@drwtsn95 drwtsn95 commented May 29, 2025 •
edited
Loading

  • Updates op-geth to v1.101511.0

This could resolve the syncing issues of recent days. Inspired by #470.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented May 29, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@0xsimulacra
Copy link

0xsimulacra commented May 30, 2025

Hello,

This might be not 100% the full change needed.

As per op-node/v1.13.3 realease page, the coresponding op-geth version needed for this release is v1.101511.0.

@drwtsn95 drwtsn95 changed the title Update op-node to v1.13.3 for geth-based build Update op-node and op-geth for geth-based build May 30, 2025
@drwtsn95
Copy link
Contributor Author

drwtsn95 commented May 30, 2025

Hello,

This might be not 100% the full change needed.

As per op-node/v1.13.3 realease page, the coresponding op-geth version needed for this release is v1.101511.0.

Thank you. I was too fixated on the fact that this update helped me overcome synchronization issues and didn't pay attention to the accompanying op-geth update. Fixed.

@danyalprout
Copy link
Collaborator

danyalprout commented Jun 15, 2025

Thanks for opening this, happy to merge in but would you be able to rebase. On master we're currently controlling versions in this file.

@drwtsn95
Update op-geth for geth-based build
c0db288 
Updated op-geth to v1.101511.0
@drwtsn95 drwtsn95 changed the title Update op-node and op-geth for geth-based build Update op-geth for geth-based build Jun 16, 2025
@drwtsn95
Copy link
Contributor Author

drwtsn95 commented Jun 16, 2025

Thanks for opening this, happy to merge in but would you be able to rebase. On master we're currently controlling versions in this file.

Thank you. Done. This PR updates only op-geth for now, because op-node was already updated here: https://github.com/base/node/pull/477/commits without any annotations, so for now history is a little bit dirty. Earlier, PR was intended to update both dependencies.

@danyalprout danyalprout self-requested a review June 16, 2025 16:47
danyalprout
danyalprout approved these changes Jun 16, 2025
View reviewed changes
versions.env
export OP_GETH_TAG=v1.101503.4
export OP_GETH_COMMIT=2b9abb39077cb88f6e8a513f09a5ea2c2569dfed
export OP_GETH_TAG=v1.101511.0
export OP_GETH_COMMIT=68075997f33907401a93216aa426514c5ddc8870
Copy link
Collaborator

@danyalprout danyalprout Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified commit from here

@danyalprout danyalprout merged commit cfd8eca into base:main Jun 16, 2025
7 checks passed
sscornelius added a commit to sscornelius/node that referenced this pull request Jun 16, 2025
@sscornelius
Revert "Update op-geth for geth-based build (base#473)"
ff7e328 
This reverts commit cfd8eca.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danyalprout danyalprout danyalprout approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drwtsn95 @cb-heimdall @0xsimulacra @danyalprout